Re: Suspicious chain of checks

On 07.09.2011 16:48, Dmitry wrote:
> Hey.
>
> Currently CCopyDlg::OnCheck() reads:
>
> bool check = false;
> if (hwnd == GetDlgItem(IDC_CHECKALL)->GetSafeHwnd())
> check = true;
> else if (hwnd == GetDlgItem(IDC_CHECKNONE)->GetSafeHwnd())
> check = false;
>
> Here if the first condition holds true "check" is asssigned true. Otherwise the second condition is checked and if that holds true "check" is assigned the initial value. The code has the following effect:
>
> bool check = false;
> if (hwnd == GetDlgItem(IDC_CHECKALL)->GetSafeHwnd())
> check = true;
>
> Was anything else meant in that code?

Fixed in r21953.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2836513
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].