Re: r21936 is damn suspicious

On 05.09.2011 14:37, Dmitry wrote:
> Hey.
>
> May I wonder why r21936 was committed?

To reduce the memory allocated on the stack by allocating the memory on
the heap instead.

> Currently it uses raw pointers and this is not exception-safe. Also

I don't quite see the problem here?

> in TortoiseIDiff.cpp if control flows through "return (int)
> msg.wParam;" the window object is not deleted.

Fixed in r1943.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2835656
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].