[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Editing svn:externals that uses peg revision equal to operative

From: Konstantin Kolinko <knst.kolinko_at_gmail.com>
Date: Fri, 26 Aug 2011 23:45:26 +0400

2011/8/26 Stefan Küng <tortoisesvn_at_gmail.com>:
> On 26.08.2011 19:47, Konstantin Kolinko wrote:
>> 2011/8/26 Stefan Küng<tortoisesvn_at_gmail.com>:
>>> On 26.08.2011 15:19, Konstantin Kolinko wrote:
>>>> This is about the dialog that is used to edit the value of
>>>> svn:externals property in TSVN 1.7.
>>>>
>>>> If I edit svn:external that uses  @rev, and specify the same peg and
>>>> operative revisions, it saves it as
>>>>
>>>>     -r operative url_at_peg localname
>>>>
>>>> 1. In case both revisions are equal I would like the saved value to be
>>>> more simple:
>>>>
>>>>     url_at_peg localname
>>>>
>>>> Note that in Subversion the operative revision by default equals to the peg one.
>>>
>>> Nope, that's not what happened in my tests. The operative revision
>>> defaults to HEAD.
>>
>> That is what happens in mine:
>>
>> [[[
>> \tc7.0.x\trunk>svn up
>> Updating '.':
>>
>> Fetching external item into 'modules\jdbc-pool':
>> External at revision 1162102.
>>
>> At revision 1162183.
>> ]]]
>
> Ok, so you're right.
> But still: what's the harm in specifying the op rev as well? Id doesn't
> have to look pretty, it only has to work correctly.

A magic number that is 7 digits long makes me nervous. I would prefer
to specify it only once.

Anyway the good old "Advanced" edit dialog is still there.

> And adding code to prettify the externals string (which users won't pay
> attention to anyway since the editing is done with the prop dialog)
> would just add the risk of new bugs.
>

Best regards,
Konstantin Kolinko

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2830740

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-08-26 21:45:28 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.