[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Language resource DLL in TortoiseSVN is never unloaded

From: Konstantin Kolinko <knst.kolinko_at_gmail.com>
Date: Tue, 2 Aug 2011 15:39:16 +0400

Hi!

I noticed the following issue when reinstalling betas:
If I use non-localized version of TortoiseSVN reinstallation goes
smoothly without need to reboot.

If I use localized version, reinstallation does require reboot.
The cause is that the localization library, e.g.
Languages\TortoiseProc1049.dll remains locked.

Looking at the sources I see that
 CTortoiseProcApp::InitInstance() in TortoiseProc.cpp loads the DLL,
but it is never unloaded.

Would it be safe in CTortoiseProcApp::ExitInstance() to
1) call AfxSetResourceHandle( ) with its default value (NULL ?), and
2) unload the DLL ?

It is a minor issue, though, because in normal use reinstalls do not
happen frequently.
A possible workaround is to rename the old dll (or the whole Languages
folder) before installing new version.

I am using WindowsXP 32-bit.

Best regards,
Konstantin Kolinko

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2808142

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-08-02 13:39:20 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.