Suspicious error handling code

Hey.

Currently SubWCRev::GetWCInfo() reads:

if (wcPath==NULL)
        return ERROR_INVALID_PARAMETER;

The problem is ERROR_INVALID_PARAMETER is defined as numeric constant 77 in WinAPI headers, so SUCCEEDED will evaluate to "true" on this value and any well-obeying caller will think the output parameters have been set. I suspect it should be E_INVALIDARG instead.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2805354

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-07-28 16:35:42 CEST