Suspicious duplication
From: Dmitry <wipedout_at_yandex.ru>
Date: Thu, 30 Jun 2011 13:21:13 +0400
Hey.
Currently CBaseView::HasNextInlineDiff() and CBaseView::HasPrevInlineDiff() are implemented identically. To me that makes no sense and maybe it is an error. Even if it is how it should be there's no reason to have two identically implemented nontrivial functions - either one should call another instead or both should call a third function named something like "HasInlineDiffs()`.
Duplication was detected using PVS-Studio static analysis tool.
Best wishes.
------------------------------------------------------
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
|
This is an archived mail posted to the TortoiseSVN Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.