Re: Suspicious logical expression

On 29.06.2011 09:25, Dmitry wrote:
> Hey.
>
> Currently TortoiseBlame::SetupLexer() reads
>
> if (lineptr)
> {
> _tcscpy_s(line, lineptr+1);
> _tcslwr_s(line);
> if ((_tcscmp(line, _T("py"))==0)||
> (_tcscmp(line, _T("pyw"))==0)||
> (_tcscmp(line, _T("pyw"))==0))
>
> the inner if performs the very same check twice in a row. Perhaps the second check is unneeded or mistyped. This defect was detected using PVS-Studio static analysis tool.

Fixed in r21634.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2780563
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].