On 16.06.2011 22:05, Stefan Küng wrote:
> This one is for Stefan^2:
>
> * show the log for the 1.6.x branch of TSVN, in the log dialog check
> the box "stop on copy/rename", close the dialog
> * clear the log cache (settings dialog, saved data)
> * show the log for the 1.6.x branch of TSVN again, click on "Next XXX"
> until the branch creation is found (r15693)
This is exactly the problem: Google does not report r1569*2*,
which would be the right branch creation revision.
> * uncheck the box "stop on copy/rename"
>
> now click on the "Next XXX" button as many times as you like: the log
> won't get fetched beyond the copy/rename anymore, even though the
> checkbox isn't checked.
>
> In CacheLogQuery.cpp:1000:
> iterator->GetRevision() returns 0, even though the iterator is an
> CCopyFollowingLogIterator and we're not at rev 0 yet.
Since the copy operation never showed up, the cache assumed
that everything before that could be skipped in later requests.
Hence, it arrives at revision 0 in a single iteration.
>
> Not sure what's the best way to fix this, so I leave this to you :)
Fixed in r21587.
I simply removed the code that would store the final "skip range".
That will only hurt performance if the initial add / copy operation
cannot be found. Even with GoogleCode, the next log request
will fetch the initial add (plus more revs on the /trunk) and subsequent
calls will nicely terminate at the proper branch creation rev.
-- Stefan^2.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2769087
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-06-18 15:33:07 CEST