RE: Passing url files into diff viewer.

(Replying to Stefans mail, but actually more to Artem...)

>>> So what is the benefit of you getting the files via yet another
>>> SVN-client versus letting Tortoise provide the files for you?
>> For example, we will be able to show the author of changes line
>> by line (using svn blame).
> so basically the same as "blame differences" already does. Just
> use the output of that.

Sweet! But I think the goal here would be to have the blame data seamlessly integrated in the diff command. The need to use a separate command for it sort of defeats that purpose.

Is there any other data from SVN that you are planning on adding to the diff except for the blame information?

>>> Also, I think that you could fairly easily try this modification
>>> out if you build TortoiseSVN yourself.
>> We can modify TortoiseSVN by ourself, but can we rely on the patch
>> being included in release version?
> If the patch is correct, doesn't break anything and is actually
> useful, it will be included.

Well, the good news is that TortoiseSVN is already able to provide the info you need, without you having to get the data "on the side". A patch could then provide another special keyword in "Settings"->"External Programs"->"Diff Viewer" where you set your external diff viewer. For example in addition to %base the keyword %blamefile could be used to indicate to TortoiseSVN to create a blame differences file and to pass the path to that file to the external tool in place of the keyword. This would however have the downside of slowing down all diff operations...
Hmm... I'm starting to warm to your idea of being able to pass the remote paths to the diff-tool. The diff-tool could then get the extra data in the background. It's not optimal, but perhaps the only viable solution to get seamless blame data in a diff.
Anyway, I guess some extra keywords for the configuration of external diff-tools would be the way to go either way.

If you make a clean and nice patch I think it should have a good chance of making it into the next release. Just make sure to post it as soon as possible to be able to get feedback on it and to have time to make any suggested changes in time for 1.7. Good luck!

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2755134

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-06-01 08:38:37 CEST