[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

TortoiseMerge nightly build crash

From: Hans-Emil Skogh <Hans-Emil.Skogh_at_tritech.se>
Date: Mon, 23 May 2011 07:20:25 +0000

Hi!

Over all I think that TortoiseMerge is starting to work somewhat better again. Good job!

However, I’m getting a crash every now and then. I have been trying to come up with a recipe but failed. I believe it has something to do with some combination of enabling/disabling wrapping of long lines, moving the separator between the left and right side and possibly resizing the whole window.
The crash is because of a call to GetTextExtentPoint32() on line 1643 in baseview.cpp with a string length which is far too long, leading to a memory access violation.

Callstack up to the GetTextExtentPoint32()-call:
... crash
TortoiseMerge.exe!CBaseView::DrawTextW(CDC * pDC=0x0013f7e0, const CRect & rc={...}, const wchar_t * text=0x00d83f80, int textlength=7, int nLineIndex=12, tagPOINT coords={...}, bool bModified=true, bool bInlineDiff=true, int nLineOffset=0) Line 1644
TortoiseMerge.exe!CBaseView::DrawInlineDiff(CDC * pDC=0x0013f7e0, const CRect & rc={...}, int nLineIndex=12, const ATL::CStringT<wchar_t,StrTraitMFC_DLL<wchar_t,ATL::ChTraitsCRT<wchar_t> > > & line="￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿￿", CPoint & origin={...}) Line 1703
TortoiseMerge.exe!CBaseView::DrawSingleLine(CDC * pDC=0x0013f7e0, const CRect & rc={...}, int nLineIndex=0) Line 1794 + 0x24 bytes
TortoiseMerge.exe!CBaseView::OnDraw(CDC * pDC=0x0013f868) Line 1319 C++
...

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2745787

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-23 09:20:37 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.