[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [T-Merge Patch] Convert Text Selection to view coordinates

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 06 May 2011 17:48:00 +0200

On 06.05.2011 17:43, Oto BREZINA wrote:
> On 2011-05-05 22:00, Stefan Küng wrote:
>> On 05.05.2011 21:05, Oto BREZINA wrote:
>>> * Convert Text Selection to view coordinates
>>> * keep text selection over wrap line, window resize
>>> * fix editing in wrap mode - for speed cost
>>> * fix mark word while wrap on
>> Too much of a performance problem with this one:
>> You rebuild the screen2view vector on every entered char. While that
>> would be acceptable (very bad, but acceptable for those who don't type a
>> lot) if that method were only used when typing, it's also used when
>> pasting text from the clipboard.
>> Try pasting a few lines of text and you'll see what I mean.
> If there are no other issues like this (and "FIXME" thing) can commit
> it? I have almost ready paste fix attached
> * use line based paste
> * add line numbers to new lines
> * add empty lines to other views
> * remove "log" from windows registry keys names
> * ... maybe more but hidden in other changes
> , and I hope I would start to solve type performance issue soon I have
> some idea how to rebuild only (affected) part of screen2view vector.
> You may comment out building screen2view for this commit if you think is
> that big issues. I like to have patched targeting different issue in
> separate commits, but as you can see I change independed issues anyway ...

Looks good. Just one small thing:
Change the comment //FIXME to // TODO: and explain in the comment what
exactly needs fixing.
Also the pragma you used
#pragma warning
doesn't work that way. If you want the compiler to output your text, you
have to use
#pragma message ("my text goes here")


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-06 17:48:07 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.