[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: Local changes to externals (Was: Removing externals)

From: Daniel Klima <danklima_at_gmail.com>
Date: Thu, 5 May 2011 14:44:41 -0700 (PDT)

> On 05.05.2011 09:22, Hans-Emil Skogh wrote:
> >>>>> It ignores all externals.
> > ...
> >> It ignores *local* changes to the svn:externals property by
> >> default now. Only if you commit the changes, the default update
> >> will also update the externals. If you want to have 'update'
> >> respect your local modifications to the svn:externals property, you
> >> have to do so in the "update to revision" dialog now.
> >
> > Oh! I think this is pretty bad. It really flies in the face of all
> > test-before-you-commit practices. :-( If this change goes through I
> > think I'll be seeing a lot more of broken commits, where externals
> > are involved...
> >
> > Is there any way we can improve this on the TSVN-side? Either by
> > making an update always honor the current WC state of all
> > svn:externals properties (my preference), or by adding a checkbox to
> > the edit svn:externals dialog that does the update automatically if
> > the external is changed (hopefully default-checked..).
>
> I'll add an option to change the default.
> The current default is what the CL client will use as its default too,
> because checking for local mods to external props takes a long time and
> this was done for performance reasons.
>
> Stefan

Considering number of exterenals in some projects/repos (like gpuocelot) any time lost on this will be far outweighted by time lost on externals.

Anyway, thanks.

Klimax

P.S.:
Gpuocelot - https://gpuocelot.googlecode.com/svn/trunk

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2731367

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-06 04:57:21 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.