[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: TortoiseMerge right click behavior

From: Oddvar Kloster <Oddvar.Kloster_at_sintef.no>
Date: Wed, 30 Mar 2011 10:11:53 +0200

> -----Original Message-----
> From: Stefan Küng [mailto:tortoisesvn_at_gmail.com]
> Sent: 29. mars 2011 21:22
> To: dev_at_tortoisesvn.tigris.org
> Subject: Re: TortoiseMerge right click behavior
>
> On 29.03.2011 12:54, Hans-Emil Skogh wrote:
> > Hi!
> >
> > When right clicking on a (non-selected) line in TortoiseMerge I would
> > expect that line to be selected and the context menu to appear. Right
> > now the context menu appears but the selection is not affected. This
> > is confusing since it is far too easy to perform unintended actions on
> > selected lines that might even not be on screen.
>
> Fixed in r21082.
>
> Stefan
>

That one didn't come though correctly. If you left-drag a selection and right-click inside it, the selection changes, making operation on custom blocks impossible.
I attach a patch to fix this. The rule used now, which seems to cover everything, is very simple: If right-click is inside selection, keep it, otherwise, select block under cursor. This also simplifies the code, making some logic on when to clear the selection obsolete.

Oddvar

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2715202

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-03-30 10:20:17 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.