Re: [patch, suggestion, notes] for Applying CAutoHandle (r21053, r21058)

On 26.03.2011 22:22, Oto BREZINA wrote:
> Hi Stefan,
>
> great work with briliant design!
>
> Here are some comments, notes, fixes I did while checking CAutoHandle
> implementation and usage.
>
> I'm sorry that some are unrelated. In some cases both alternatives are kept.
>
> Have a nice day.

Wow! Thanks for all your comments.
Here my thoughts on those:

return value in CDirWatchInfo::CloseDirectoryHandle(): the return value
is nowhere used, so it's ok to change the value to true in case the
handle could be closed properly.

TSVNCache.cpp: reload protection mutex wasn't closed before: that worked
before too since the mutex is released by the OS automatically when the
process finishes. Only now with the CAutoHandle we close it ourselves.

Closing thread handles is not necessary since those are pseudo-handles,
and most people don't even use those (i.e., ignore the return value of
the beginthreadex function).

I've committed the rest of your suggestions.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2714532
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].