[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch, suggestion, notes] for Applying CAutoHandle (r21053, r21058)

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 27 Mar 2011 11:44:44 +0200

On 26.03.2011 22:22, Oto BREZINA wrote:
> Hi Stefan,
> great work with briliant design!
> Here are some comments, notes, fixes I did while checking CAutoHandle
> implementation and usage.
> I'm sorry that some are unrelated. In some cases both alternatives are kept.
> Have a nice day.

Wow! Thanks for all your comments.
Here my thoughts on those:

return value in CDirWatchInfo::CloseDirectoryHandle(): the return value
is nowhere used, so it's ok to change the value to true in case the
handle could be closed properly.

TSVNCache.cpp: reload protection mutex wasn't closed before: that worked
before too since the mutex is released by the OS automatically when the
process finishes. Only now with the CAutoHandle we close it ourselves.

Closing thread handles is not necessary since those are pseudo-handles,
and most people don't even use those (i.e., ignore the return value of
the beginthreadex function).

I've committed the rest of your suggestions.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-03-27 11:44:55 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.