[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Conceptual Patch - Handle wrapper class

From: Oto BREZINA <otik_at_printflow.eu>
Date: Fri, 11 Mar 2011 13:40:09 +0100

Hello Stefan,

After you commit patch I sent you (r20974), I checked if there are other
places with similar issues. I found out that wrapping class may help
here. It adds some overhead but not much. Some optimization can be still
done by trade it for readability and maintainability.

This is conceptual patch and is not intended as patch to be commit as is
(especialy for may English (better to say English like language :) )). I
don't have VC so I did not try to even compile it.
If you are not interesting about this in TSVN no problem, just let me know.

If you interest in it. There may be answers which may help to improve it.
Is there any situation when 0 is valid handler ?
   If no: would be better to use NULL (0) as Invalid handler.
   It may simplify test for invalid handle a bit, also bValid attribute
may be removed from class.
   As I understand INVALID_HANDLER_VALUE is for compatibily with win16 API.
Is there any situation when INVALID_HANDLER_VALUE is valid handler?
  if both are no: we don't need to pass invalid value into object
Is there any real bed efect when we call CloseHanlde with 0 or
pseudo handler to windows itself, or something like that.

Oto BREZINA, Printflow s.r.o., EU
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-03-11 14:11:38 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.