[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TSVNCache problem

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 18 Feb 2011 17:01:23 +0100

On 18.02.2011 11:56, Hans-Emil Skogh wrote:
>>>>> From your description I guess this is an issue with a deadlock
>>>>> somewhere in the cache. I have a look at this, but deadlocks are
>>>>> hard to find and to reproduce so this might take me a while to
>>>>> fix...
>>> I got it again a couple of times yesterday. I successfully attached
>>> the debugger to TSVNCache.exe, but didn't get that much wiser...
>> What did the debugger show you? Nothing at all or maybe functions where
>> each thread was at? Anything could help here because I'm unable to
>> reproduce this problem here.
>
> I got a full stack trace on each of the threads. I got it again today and I saved mini-dumps from two separate occasions. (Looks very similar though.)
>
> I will mail them directly to you to avoid spamming the list (as well as disclosing any possibly sensitive information).

Thanks for the dump files.
But as you already figured out, the dumps really are inconclusive and
don't provide enough information :(

But: the two second timeout is in play here when waiting for a reader
lock to return the status info back to the explorer. Now that can only
happen if a writer lock is active. From the dumps however it doesn't
seem that there actually is such a writer lock active since no
stacktrace is in a code path that has such a writer lock acquired. This
might be a bug in the reader/writer class we're using here.

If it happens again, could you maybe try and see if
m_impl.m_iNumOfWriter in ReaderWriterLock.cpp, line 381 is bigger than zero?

I've committed a fix for a possible but unlikely race condition in our
reader/writerlock class (r20896), but since I can not reproduce the
issue you're experiencing I can only ask you to test the next nightly
build again.

I just hope we can get this fixed soon so you can work on your own
projects again and don't have to do all this work for TSVN.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2705364
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-02-18 17:01:43 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.