Re: Patch - wrong casts, no cleanup in destructor

On 07.02.2011 07:58, Dmitry wrote:
> Hey.
>
>>> That code is copied from CShellExt in TortoiseShell, where the class
>>> is indeed inherited from all those interfaces. static_cast works
>>> there - I copied that code into a separate project to test. If
>>> static_cast was used initially the compiler would prevent such
>>> unfortunate use of copy-paste.
>> Ups. You're absolutely right.
>> Fixed in r20823.
>
> Attached is an untested patch with more of the same in all other COM servers.

Committed in r20823.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2702691
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].