[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - wrong casts, no cleanup in destructor

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 03 Feb 2011 20:18:07 +0100

On 03.02.2011 08:40, Dmitry wrote:
> Hey.
>
> Attached is an untested patch that addresses:
> - cleanup code in Release() method instead of in destructor - the destructor is called from Release() anyway

Committed in r20818.

> - C-style casts where static_casts would be safer (compiler will show an error if a cast is not possible in case of static_cast, but not in case of C-style cast)

static_cast doesn't work here because ppv is a void pointer.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2702191
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-02-03 20:18:34 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.