Changes in r20767 break existing error handling.

Hey.

Changes in r20767 significantly change functionality. For example look at previously existing CMainFrame::RunTortoiseProc(). It worker this way:
1. start the process
2. if process started okay - do nothing
3. otherwise show an error message

Now, when it is replaced with a call to CAppUtils::RunTortoiseProc() which redirects to CAppUtils::LaunchApplication() it will work this way:
1. start the process
2. if the process has not started and the "message id" passed is not null - show an error message and exit, but the "message id" passed will be always null, so there will be no error message
3. if it started - do a whole bunch of stuff like call WaitForInputIdle(), etc.

This behavior changes are the number one reason I haven't submitted such patch myself - I planned to reduce duplication slowly, until it is clear which different ways to run the process are there and only then offer sime unification.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2700495

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-01-26 07:26:45 CET