Suspicious code in TMerge MainFrm

From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 24 Jan 2011 15:23:55 +0300

Hey.

In TMerge MainFrm there're two similar pieces of code for starting TProc. In one case there's a call to GetAppDirectory(), in the other one - to GetModuleFileName. Is there any reason for that? If that's not necessary attached is an untested patch that reduces duplication.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2700110

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

application/octet-stream attachment: Patch_-_CodeDuplicationInTMergeMainFrm.patch

Received on 2011-01-24 13:24:08 CET

This message: [ Message body ]
Next message: Stefan Küng: "Fwd: Re: Diff for MS Word 2010 docx documents?"
Previous message: Lübbe Onken: "TortoiseSVN translation status report for r20759"
Next in thread: Stefan Küng: "Re: Suspicious code in TMerge MainFrm"
Reply: Stefan Küng: "Re: Suspicious code in TMerge MainFrm"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]