Patch - code duplication in SVNStatusListCtrl

Hey.

Attached is an untested patch that reduces code duplication and removes an unused tstring variable in SVNStatusListCtrl.

I don't quite like the for-loop that now will be inside CSVNStatusListCtrl::BuildIgnoreList(). It goes up the indices and overwrites the "value" variable. I suppose there's no side-effect in the loop body.

If more than one match is possible is it will unnecessarily overwrite "value" until it finds the last match. If the logic behind that code is that there's no more than one match ever then there's no need to continue running the loop after the first match. In the first case the loop should go down the indices and break on first match, in the second case it should go up the indices and break on the first match.

Do I get it right?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2698844

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].