> On 01.01.2011 17:21, Daniel Klima wrote:
> > Hello.
> >
> > I ran
> > Cppcheck(http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page)
> > against trunk and fixed some performance problems. Not all as there
> > seems to be still a lot of false positives.
> >
> > Each patch file is against a single file and type of change. Not
> > compiled nor tested,but changes seemed to be trivial.
>
> I prefer one patch file with all the changes. Less work for you and for
> me: for you to create it and for me to apply it.
>
Noted for next patches.
> > Two resources.h had BOM looking like UTF-16 and were marked as
> > application/octet-stream. I resaved them as BOM-less UTF-8 and
> > removed property.
>
> VS2010 automatically converts the rc and resource.h files to UTF-16 when
> necessary. Your patch changes the header files, but they would get
> changed back to utf-16 with the next resource change automatically. So
> let's just leave those files as they are.
>
> Committed your patch with slight modifications in r20661.
>
> Stefan
Shows what I know about VS... understood.
Klimax
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2695490
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-01-02 18:54:00 CET