[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suspicious code inside CLogDlg::OnFindDialogMessage()

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 15 Dec 2010 20:25:16 +0100

On 15.12.2010 10:12, Dmitry wrote:
> Hey.
>
> I noticed suspicious code in CLogDlg::OnFindDialogMessage(). There's "bool bFound" variable that is assigned once and never changed but used in the for-loop ending condition. Why is it there? Should the loop body modify it or is it just unneeded?

That variable was used before we used the filter class. It's not needed
anymore now.
I've removed it in r20613.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2690980
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-12-15 20:25:45 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.