[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch - code duplication and minor problems in Log dialog

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 07 Dec 2010 16:48:31 +0300

Hey.

Attached is an untested patch that addresses issues in Log dialog:
- code duplication
- too wide scope of variables
- too deep nesting
- risk of undefined behavior if buffer is completely used
- wrong size of buffer passed into function

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2688471

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2010-12-07 14:48:41 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.