[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: Various constants abuse

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 23 Nov 2010 10:26:31 +0300


Yes, I agree about dropping an extra parameter where possible. I don't agree about MAX_PATH, but its your code.

However I can't agree about omitting the part which corrected SecureZeroMemory calls - when you zero out the buffer you zero it out entirely, don't you? Attached patch addresses this specifically.

Best wishes.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2010-11-23 08:26:38 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.