Re: Patch: Various constants abuse

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 23 Nov 2010 10:26:31 +0300

Hey.

Yes, I agree about dropping an extra parameter where possible. I don't agree about MAX_PATH, but its your code.

However I can't agree about omitting the part which corrected SecureZeroMemory calls - when you zero out the buffer you zero it out entirely, don't you? Attached patch addresses this specifically.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2684854

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

application/octet-stream attachment: Patch-ZeroingOutIncorrectly.patch

Received on 2010-11-23 08:26:38 CET

This message: [ Message body ]
Next message: Dmitry: "Strange pattern with a dangling pointer in TProc"
Previous message: hangzhang: "RE: Re: How to use TortoiseOverlay in my own application"
In reply to: Dmitry: "Patch: Various constants abuse"
Next in thread: Simon Large: "Re: Patch: Various constants abuse"
Reply: Simon Large: "Re: Patch: Various constants abuse"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]