[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Checked TortoiseSVNs code with cppcheck

From: <Stefan.Fuhrmann_at_etas.com>
Date: Mon, 4 Oct 2010 13:50:11 +0200

"Philipp K." <philipp.kloke_at_web.de> wrote:

> I used cppcheck to analyze the source code of TortoiseSVN.
> Cppcheck claims to have found three errors and some style problems
> (I highlighted the errors with "->> " to make it easier for you to find
them in
> the long list because they are probably more important than the style
annotations.)

Hi Philipp,

thanks for running the analysis. I will see what can done reasonably
for the style issues.

As for the errors, only the one in TortoisePLink seems to be valid.
An fclose(fp) should be added here but I can't test that here.

The error reported for zlib is not an error because destroy(s) will
also free s->path and the code dereferencing the NULL pointer
in CrashCommand has been put there deliberately.

-- Stefan^2

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2667787

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-10-04 13:50:23 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.