RE: URL Character substitution in repo-browser

> -----Original Message-----
> From: Oddvar Kloster [mailto:Oddvar.Kloster_at_sintef.no]
> Sent: 23. september 2010 15:32
> To: dev_at_tortoisesvn.tigris.org
> Subject: RE: URL Character substitution in repo-browser
>
> > From: Stefan Küng [mailto:tortoisesvn_at_gmail.com]
> > Sent: 21. september 2010 21:00
> > To: dev_at_tortoisesvn.tigris.org
> > Subject: Re: URL Character substitution in repo-browser
> >
> > On 15.09.2010 09:07, Oddvar Kloster wrote:
> > > Hi.
> > >
> > > I encountered this problem when accessing an odd-named repo using
> > > the
> > repo-browser.
> > >
> > > 1. Open the URL http://<server>/Scoop# in repo-browser.
> > > 2. In tree view, select 'trunk'
> > > -> URL at top changes to http://<server>/Scoop%23/trunk No
> > > -> subitems of trunk are shown in the right view.
> > > 3. Expand 'branches' by clicking the + icon
> > > -> Error as shown in attachment
> > >
> > > If I press F5 on the root node, everything is OK.
> > > Using nightly r20092
> >
> > Is the repository named "Scoop#"? Because if I try with a folder name
> > inside a repository that's named "Scoop#" I don't get any problems.
> >
>
> Yes, the repository is named "Scoop#".
> The problem depends on which folder in the repo you originally opened in
> the repobrowser. Only folders below the original are affected.
>
>

I've traced the cause of the problem.

In RepositoryBrowser.cpp, line 348, the initial value of m_repository.root is fetched. This value is escaped, and the escaped value is used in line 358. This causes all nodes below the original node to receive an escaped url. The path is unescaped in line 443, so nodes generated from there on from the repo root receive a correct url.
The attached patch corrects the problem.

Oddvar

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2665109

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].