[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: Show change on all navigation

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 10 Sep 2010 16:50:35 +0200

On 09.09.2010 19:01, Oddvar Kloster wrote:
>> Thanks!
>> Committed in r20082 (with a very minor tweak).
>
> I’m unsure why you made the tweak. The idea was to move to the new line,
> force a scroll to the far left and then go to the first inline diff,
> which automatically scrolls right as necessary. Now, if I come from a
> line with a change far to the right to a new line with a change near the
> beginning, it will scroll so that the change is just outside the left
> edge of the view.

The tweak was to avoid scrolling several times. But I guess it broke
what you intended?

> Two other suggested changes (in attached patch):
>
> - Replace Scroll with ScrollAll to always keep views in sync
>
> - Ensure that the OtherView is set when looking for the first change
> when initially moving to first diff.

Committed in r20098

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2657549
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-09-10 16:51:02 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.