[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: Re: Crash in repo browser

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: Wed, 21 Jul 2010 22:17:44 +0100

n 18 July 2010 22:50, Simon Large <simon.tortoisesvn_at_googlemail.com> wrote:
> On 17 July 2010 16:10, Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de> wrote:
>> Simon wrote:
>>> On 17 July 2010 11:52, Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de> wrote:
>>> > Stefan Küng wrote:
>>> >> Analyzing the crash dump Simon sent me:
>>> >>
>>> >> A "priviledged instruction" exception is thrown when a thread is ended
>>> >> (in AfxEndThread). But the exception points to a bug somewhere else
>>> >> because such exceptions usually happen because of a stack corruption.
>>> >>
>>> >> So we have to look for places where we might corrupt the stack...
>>> >
>>> > Sorry that it took me so long to reply but I'm still
>>> > fighting a hefty influenza.
>>> >
>>> > Anyway, it seems that nothing is wrong with the actual
>>> > "edit file" or repobrowser logic but some race condition
>>> > in the dialogs invoked makes it crash. Please disable the
>>> > "General->Dialogs1->Autoclose" setting and try again.
>>> >
>>> > If it doesn't crash then, please create the DWORD reg
>>> > key "SimonsCrashHack" and set it to 1 through 3 and test
>>> > again for each value. This will basically select
>>> > different combinations of auto-close settings in the
>>> > hope that one of them can be identified as the trigger
>>> > for those crashes you are experiencing.
>>>
>>> No joy. Auto-close was already disabled (Close manually, Auto-close
>>> for local ops unchecked).
>>>
>>> Remember that Open with... works fine, Edit does not.
>>
>> The thing is that "edit" will perform a checkout
>> (actually two) but instructs the progress window to
>> hide & auto-close by default (the short flicker is
>> that progress window). This has been disabled for the
>> next nightly. But if you had these windows auto-close
>> as per your settings, they still could crash if the
>> auto-close behaviour is source of the problem.
>
> OK, we're getting somewhere now.
> Reg key not set: works
> Reg key = 1: works
> Reg key = 2: crash (sometimes)
> Reg key = 3: crash (sometimes)
>
> After a crash I close the TSVN crash report dialog and the windows
> close but TortoiseProc.exe process sits there consuming 100% CPU.

I have now deleted the SimonsCrashHack key and I can confirm that the
latest changes have fixed the crash.

The issues listed below were unrelated and still stand of course.

> Other things worth noting, unrelated to the crash problem:
>
> While the editor is open the repo browser window does not repaint if
> you swap back to it. In fact it takes about a second after the editor
> exits before it redraws itself.
>
> Once when I tried to open version.txt for edit I got a message in the
> checkout progress to say that it was a file not a directory. I only
> saw that once and cannot reproduce it.
>
> Other attempts to open version.txt were OK, but when the editor closes
> it always shows as modified. I note that the working base has
> svn:eol-style set to native and the working copy has no such property.
> As a result, the working copy appears to have LF line-endings and the
> working base has CR-LF.
>
> I am testing on a single core CPU in case it makes any difference.

Simon

-- 
:       ___
:  oo  // \\      "De Chelonian Mobile"
: (_,\/ \_/ \     TortoiseSVN
:   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
:   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2636491
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-07-21 23:17:56 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.