On 8 July 2010 19:59, Simon Large <simon.tortoisesvn_at_googlemail.com> wrote:
> > On 8 July 2010 16:08, Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de> wrote:
> >> Simon wrote:
> >>> On 4 July 2010 20:43, Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de> wrote:
> >>> > Simon wrote:
> >>> >> This still crashes in r19795. Any further clues?
> >>> >>
> >>> >> Simon
> >>> >
> >>> > In r19806, I added a ton of debug output to narrow
> >>> > down the source of your crashes. Please set the
> >>> > Software\\TortoiseSVN\\DebugOutputString DWORD regkey
> >>> > to 1 and use DbgView or a similar tool to collect the
> >>> > output.
> >>>
> >>> Using r19829 (full build). DbgView.log attached.
> >>
> >> From the debug log it seems that it is really the
> >> invocation of the external editor that somehow makes
> >> TSVN crash. There is a remote possibility that r19849
> >> will the problem. It will at least give more detail on
> >> the code that triggers the crash.
> >
> > Not the editor itself because I deliberately chose a file which has no
> > file association to force the "Select Text Editor Application" dialog
> > to come up instead of a real editor. I will try the new version
> > tomorrow.
>
> This is the output for r19858
> <-- snip -->
> 00000090 28.69889069 [2840] EditFileCommand::AutoCheckout done
> 00000091 28.70235634 [2840] #43 Thread:3112
> SVNProperties::Refresh(line 119) svn_client_proplist3
> Path=C:/DOCUME~1/Simon/LOCALS~1/Temp/trunk.svn008.tmp/versioninfo.build
> 00000092 28.70736885 [2840] #43 Thread:3112 done (5025 µs)
> 00000093 29.99070168 [584] 421828 - INFO:
> CHPAiOCtxMonitor::TimerEvent: Poll...
>
> Simon
So, it seems that it doesn't even try to start the application but already fails in CCommonAppUtils::GetAppForFile. Judging from what the MSDN says, there might have been strings that were not properly terminated by a 0-character. Fixed in r19874. Please test again ;)
-- Stefan^2.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2632003
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-07-11 18:35:56 CEST