Re: New patch

On 31.05.2010 08:41, Hans-Emil Skogh wrote:

> I'm not talking about how it is done "behind the scenes", only how it
> will appear to the end user. I don't see any problem with running the
> "patch all" (or to patch an individual file) execution from within the
> (not yet existing) patch dialog. Or if that feels awkward, do it in a
> single (preferably non-visible) tortoise merge instance in the
> background. Is there a particular reason that the patch-code is located
> in TMerge?

Yes: we had our own patch code which has nothing to do with svn. So I
implemented it in TMerge, because that's also where patches get applied.

> The only time a tortoise merge window would need to be created would be
> (as in "Changed Files") when a user wants to view a diff, and the
> slowdown of starting a new TMerge instance in those cases is OK, I'd
> say. (We do not share the same TMerge instance for "Changed Files" or
> for the "Log Messages" dialog.)

And that would require to start a TMerge instance.
Sure, we could change it to do so, but I don't like that idea.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2615320
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].