[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suggestion: an additional hook script example.

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 07 May 2010 22:28:37 +0200

On 07.05.2010 22:19, Serge Tumanyan wrote:
> Stefan,
>
>>> I suggest an additional script hook example for you.
>> Sure, just commit it to the contrib folder. If you have a readme file
>> add that one too. If not, make sure you have enough comments in the hook
>> script file for others to understand what's it for.
>
> Done in the following path:
> contrib\hook-scripts\client-side\ReCompileJAWSScriptsWC.js
>
> The only thing I want to ask you to do with it is to open it in any text
> editor and to check that I have formatted the tutorial comment at the
> beginning of the script correctly for the case if any of sighted people will
> look into it. I tryed to do this - but this is usually a problem with a
> screen reader. If I have made any formatting mistakes like wrong indentation
> or the comment looks not very attractive please feel free to modify it to
> gain attractive view.

The script looks good, as does the formatting.
Just one line I'll commit a change to soon: I'll split line 12 into two
lines, otherwise it gets too long.

Another small detail:
You've added the line
"for non-commercial use only."
wouldn't it be better to just say "Licensed under GNU GPL v2" or
something like that?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2605227
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-05-07 22:28:42 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.