Re: svn commit: r18544 - trunk/src/SVN

On 08.02.2010 07:22, Stefan Fuhrmann wrote:
> Author: sf
> Date: 2010-02-07 22:22:14-0800
> New Revision: 18544
>
> Modified:
> trunk/src/SVN/SVNProperties.cpp
> trunk/src/SVN/SVNProperties.h
>
> Log:
> add serialization and deserialization facilities to SVNProperties
>
> Modified: trunk/src/SVN/SVNProperties.cpp
> Url: http://tortoisesvn.tigris.org/source/browse/tortoisesvn/trunk/src/SVN/SVNProperties.cpp?view=diff&pathrev=18544&r1=18543&r2=18544
> ==============================================================================
> --- trunk/src/SVN/SVNProperties.cpp (original)
> +++ trunk/src/SVN/SVNProperties.cpp 2010-02-07 22:22:14-0800
> @@ -1,6 +1,6 @@
> // TortoiseSVN - a Windows shell extension for easy version control
>
> -// Copyright (C) 2003-2009 - TortoiseSVN
> +// Copyright (C) 2003-2010 - TortoiseSVN
>
> // This program is free software; you can redistribute it and/or
> // modify it under the terms of the GNU General Public License
> @@ -580,6 +580,142 @@
> return IndexOf (name) != -1;
> }
>
> +namespace
> +{

* Why the anonymous namespace?
* Why not part of the class? If there's a reason for why not part of the
class, then why not in a separate file?

> + keyHeader.Format ("K %d\n", static_cast<int>(keyLength));
> + target.append ((const char*)keyHeader, keyHeader.GetLength());

You might want to document the format you're introducing here.
Also, what will the de/serialization in a custom format be used for?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2445936
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].