Patch: Refactoring LocatorBar

Hey.

The following patch addresses code duplication in LocatorBar.

Also in DocumentUpdated() some strange logic exists. "state" variable is initialized, then for each view if view data is not empty "state" is set to the state of the first line, then a loop runs where "state" might have been changed and finally "state" is unconditionally appended to the state array (m_arXXXXState.Add(state); line). Then control falls through to the next view and "state" is not unconditionally reset and so if the next view has empty view data "state" will preserve its value from the prior computations. Is that what is intended? Shouldn't "state" be reset at the same time as "identcount" is reset to 1?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2444730

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].