Re: Patch: Wrong ownership sematics for BSTRs

On 18.01.2010 17:52, Kazutoshi Satoda wrote:
> Dmitry wrote:
>> Stefan wrote:
>>> I've added (std::nothrow) to a few new calls in r18337.
>> I found some more places to add that. Patch follows.
>
> Are you aware of that adding std::nothrow doesn't prohibit throwing
> from the constructor?
>
> For example,
> new (std::nothrow) CSVNPropertyPage(files_);
> this doesn't throw if the allocation of CSVNPropertyPage itself failed,
> but does throw std::bad_alloc if an allocation fails during copy from
> files_ into CSVNPropertyPage::filenames.
>

You're right. I've added a try-catch in r18357.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2440036
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].