Re: Patch: Wrong ownership sematics for BSTRs

Stefan wrote:
>One small thing: you've introduced the CComPtr to the TortoiseOverlays
>project. But that project doesn't use MFC and ATL but only the plain
>c-runtime. No other libs - because that's the component used by all
>Tortoise clients (not just TortoiseSVN) and I'd like to keep the
>dependencies to a minimum and also the size of that component should be
>as small as possible.
>So no CComPtr for that project.
I see your point, but if you use CComPtr no library dependencies are introduced. CComPtr is just a template that calls AddRef(), Release() and QI() on whatever is passed as the template parameter. That doesn't require any libraries.

Also here comes the next patch. It adds a version of CStringUtils::PipesToNulls() that facilitates CStringUtils::PipesToNulls(whatever, _tcslen(whatever)) calls - now the same effect will be achieved in one travel along the string instead of two as it was previously. It adds a special class for holding the buffer with the file filter used with OPENFILENAME. I also made CAppUtils constructor and destructor private - that's usual practice for classes whose member functions are only called as static functions and not entity functions - and removed the implementations of those.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2437231

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].