Re: Patch: Wrong ownership sematics for BSTRs

Stefan wrote:
>There were still four compiler errors. Don't you compile your changes?
>Or test them first?
The problem is I still haven't forced myself to compile all the stuff TSVN depends on (like whatever apr.h comes from), so I can't compile the project and only test snippets in my own codebase, but that of cource doesn't guarantee against some minor compilation problems. This is the primary reason I never send patches with new functionality, only "code rewrites".

Here's more - safe arrays also leak badly - sometimes the call to release them is just absent, sometimes it is skipped because of bailing out early.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2436542

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].