Re: Patch: Wrong ownership sematics for BSTRs

On 11.01.2010 07:46, Dmitry wrote:
> Yes, I fixed an error and resend the patch. If this doesn't compile
> please let me know what it complains about, but I tested similar
> snippets in my codebase and it sould compile allright. Also you
> skipped some of the "cleanup" changes in the previous patch.

There were still four compiler errors. Don't you compile your changes?
Or test them first?

Anyway, I fixed your patch and committed it in r18299 and r18300.

One thing I won't commit: you removed the line
info = NULL;
in CPathWatcher.
Do not remove such code - even though you might think it's not necessary
(and even if it is), I don't like to have such safety statements removed.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2436363
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].