Re: [PATCH] Fix-Unrecognised String Shown in Message box during Remove Prop

On 22.12.2009 08:41, Ramasubramanian Sambamurthy wrote:
> Log:
>
> Fix for an unrecognized String shown as a Property name in a Message Box
> when Remove property is done. Stated in this thread [1]
>
> * TortoiseSVN/src/TortoiseProc/EditPropertiesDlg.cpp
>
> (RemoveProps)
>
> Made a Type cast from std::string to CString and used that as Message
> box Argument
>
> * TortoiseSVN/src/TortoiseProc/EditPropertiesDlg.cpp
>
> (OnBnClickedImport)
>

Thanks for the patch. But it's not really correct: using
CStringW("somestring") converts the "somestring" from the local codepage
to unicode. But the string is actually in UTF8, so we have to do the
conversion manually from utf8 to unicode.

Done in r18094.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2432391
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].