Re: [PATCH] Removal of Redundant Condition Checking in Logdlg.cpp

Sriram,

No, FocusChangedEventEx continues to fire on every keystroke, so I have left
a script workaround yet.

Here are the enhancements that were suggested by Oleg and implemented by me:
1. When the verbosity was set to advanced the tree view items were not
announced anymore - due to some confilict in Output types that I have now
resolved.
2. When the focus lands on the settings dialogue from the treeview to
announce the message SettingsDialogue before the control announcement.

Thank you.

With best regards,
Serge Tumanyan, Script Developer,
Freedom Scientific, Inc.
phone: 001 727-498-00-51
e-mail: STumanyan_at_FreedomScientific.com
----- Original Message -----
From: "Ramasubramanian Sambamurthy" <svram_at_collab.net>
To: <dev_at_tortoisesvn.tigris.org>
Sent: Wednesday, December 09, 2009 7:00 PM
Subject: [PATCH] Removal of Redundant Condition Checking in Logdlg.cpp

Log:

Perform a Minor Code clean-up

* TortoiseSVN/src/TortoiseProc/LogDialog/LogDlg.cpp

 (OnCancel):

Follow up on r17886. The variable 'threadsStillRunning' is been checked
in two 'if' loops. Remove redundant Check on that variable.

Patch by: Ramasubramanian S V <svram_at_collab.net>

--
Thanks & Regards,
S V Ramasubramanian
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2428892
To unsubscribe from this discussion, e-mail: 
[dev-unsubscribe_at_tortoisesvn.tigris.org].
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2428911
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].