[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: Using CComPtr for managing objects lifetime

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 23 Sep 2009 19:47:44 +0200

On 22.09.2009 12:07, Dmitry wrote:
> In TSVN code COM objects lifetime is often managed manually when there's no need for it and CComPtr can do the same job with less code.
> Also CIDataObject class is unused, seems to be superseeded with CSVNDataObject and should be removed.
> A patch (untested) is proposed.

Committed part of your patch in r17247.

One problem is that we inherit from multiple interfaces, which then
leads to the famous C2594 compiler error.
There's a workaround using a custom CComPtrEx class (use Google to find
it), but I kind of like having full control over the COM object lifetime
and full access to its objects.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-09-23 19:47:51 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.