[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

cache crawler refactor thougths

From: Gunnar Dalsnes <hardon_at_online.no>
Date: Sun, 20 Sep 2009 04:19:30 -0700 (PDT)


Saw some strange things in the crawler:
-one queue for "paths" (that can be file or folder) and one queue for folders. This seems unnecessary. Any special reason for this? If not, I will re-factor to one queue.
-All paths inside admindirs are crawled except \tmp\ \tmp and \log. This seems weird since GetStatusForMember only care about changes to .svn\dir-prop-base and .svn\entries, so I don't see the point in crawling anything but changes to these two. I will change this if no objections.

One other thing: The cached flags in CTSVNPath are scary! Got several random assert\errors because of this. Caching of these flags, at least in TSVNCache, maybe should have been disabled? Any idea what positive impact this caching had on performance?



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-09-20 13:27:54 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.