[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: reducing amount of duplicate code

From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 07 Sep 2009 11:33:32 +0400

Okay, I've factored out the code for FormatMessage(). Haven't tested it.

As for creating .cpp files just to prevent inlining the code of trivial helper classes I seriously don't understand the intent behind that. Inlining is not an inherent evil by itself and introducing an extra file that will consist mainly of the GPL header doesn't look tempting at all.

Moving error handling to one central place is not that obvious. In some cases CreateProcess() errors are silently ignored, in some cases a fixed error message is shown and in some cases it's a custom message - the logic is different each time and factoring it out is not trivial.

Best wishes.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-09-07 10:05:23 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.