Re: Patch: reducing amount of duplicate code

Dmitry <wipedout_at_yandex.ru> wrote:

> Here's more of the same - rewriting long method, eliminating duplicate
code for calling CreateProcess().

Committed with minor fixes in r17100-1.

>
> Also in ContextMenu.cpp once in a while there's a line
> svnCmd += _T("\"";)
>
> which I suppose was meant to be
> svnCmd += _T("\"");
>
> Fixed it but unsure if it was the right idea.

No that's fine. Macro expansion will remove the parenthesis
so, technically, both should be equivalent. IMHO, the second
form is to be preferred, though. Fixed further occurrences
in r17114.

-- Stefan^2.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2391009

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-09-04 14:52:07 CEST