Re: Patch: reducing amount of duplicate code

On 01.09.2009 07:14, Dmitry wrote:
> Hey.
>
> Here's a patch for reducing code duplication. Not tested - needs
> review.
>
> Also (prior to the patch) in OnCaretLeft() and OnCaretRight() first
> follows EnsureCaretVisible(), then UpdateCaret(), and in OnCaretUp()
> and OnCaretDown() the above two calls are in reverse order. Is this
> reverse order ever needed? If not, onCaretWordLeftRight() method
> could be renamed into onCaretMove() and further reused.

Thanks a lot for your patch. Committed in r17088 including your
suggestions aboout onCaretMove().

One minor nitpick: please use method names which start with a capital
letter to keep them consistent with all other method names.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2389839
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].