[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: auto_ptr is frequently abused in TSVN code

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Tue, 1 Sep 2009 00:27:36 +0200

Dmitry <wipedout_at_yandex.ru> wrote:

> Here's another patch using auto_buffer for array lifetime management. It
also addresses unused
> local CString variables found every here and there, redundant nested
code blocks and rewrites long
> methods for less block nesting and reduces code duplication.
> The patch is untested and needs a review.

Committed as r17063-6,68-70 with minor adjustments.
Thanks for the patch.

> Also in SetColorPage.cpp there is (and was) a local variable
"adjustedcolor" that is not
> initialized and passed as an in parameter to a function. That's
undefined behaviour. I have no
> idea of what correct code should be at that place.

Tentatively fixed it in r17076.

-- Stefan^2.

PS: Please open a new topic for the next patch ;)


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-09-01 00:27:48 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.