[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r16834 breaks UI under xp64

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 08 Aug 2009 18:24:51 +0200

On 08.08.2009 18:07, Stefan Fuhrmann wrote:
> Hi Stefan,
>
> wondering why the repo browser suddenly
> stopped working, I found that r16834 somehow
> prevents the browser bar windows from being
> created. I don't know whether XP32 (Win5.1)
> is affected as well.
>
> Maybe, the XPTheme is to be blamed. I will
> try to narrow it down tonight.

Strange. All changes there are no biggies. For example, changing the
windows defines to enable APIs available on Vista (not even win7!),
replacing includes to tmschema.h with vssym32.h (tmschema.h is
deprecated and will throw a compiler warning with the Win7 SDK).

That's all - I can't see any reason why this would break xp64.

> BTW, do you plan to drop W2k support in 1.7?
> If so, I would volunteer to remove all references
> to it.

Yes, and with r16834 it already is dropped: due to the win defines to
use Vista APIs, Win2k won't work properly anymore because the shim
header for multimonitor APIs isn't included anymore. So the app won't
even start due to missing dll exports.

But you don't have to go through the code and remove all win2k
workarounds - we can remove those every time we touch that part of the code.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2381633
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-08-08 18:25:14 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.