[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: overflow in "bytes transferred" portion during svn update

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 05 Aug 2009 10:08:42 +0200

On 04.08.2009 19:43, Matt Fischer wrote:
> I saw this on my Vista X64 box running Tortoise SVN 1.6.3 build 16613 -
> 64-bit. I was updating a huge chunk of files. Over 2 hours I got over
> 5GB worth of files, so my guess is that a 32-bit int is being used to
> track the number of bytes downloaded? I recommend switching to an
> unsigned long. Note that the update proceeded after the overflow, so
> this is mainly a cosmetic issue.
> I blacked out the path info to satisfy my boss.

Actually, we use an __int64 for this (more precise: the apr_off_t
typedeff). So an overflow is highly unlikely. I checked the code and I
can't find a reason why it would overflow in your case :(
But as you said: it's a cosmetic issue and I think I'll just leave it
for now until I can find a way to reproduce this without creating a 5GB


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-08-05 10:09:01 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.