[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suggestion for "select all" functionality in Commit dialog

From: Hans-Emil Skogh <Hans-Emil.Skogh_at_tritech.se>
Date: Thu, 28 May 2009 08:20:33 +0200

>> Maybe we should do that differently? Only uncheck items when "None" is
>> clicked, and 'add' the checkmarks for all others? I.e., a click on
>> "Deleted" will check all deleted items, another click on "Added" will
>> leave the deleted items checked but also check all added items?
>> If we do it that way, then disabling the links shouldn't be necessary
>> anymore?
This makes sense to me as well.
> My first idea on how to do this is as follows.
> Toggle: Added, Deleted, Modified
And what would happen if you manually uncheck half of the added files and then click added? Or unchecks all of them?
> However, if there are no "Added" items in the commit dialog, then I do not believe
> that the "Added" selection pattern link should be disabled. I think that by clicking
> "Added" when there are no added items, it should end up doing nothing at all
> except iterating every item in the commit dialog to search for items with the "Added" state.
I still thinks that options that doesn't do anything should be grayed out. If you save a document, the save option gets grayed out until you make a change. If you press undo, the button gets grayed out when there are no more things to undo. They doesn't just stay enabled wating for a user to press it and then silently do nothing.
Graying out an option does also provide additional cues to the user, like that the document has not been modified since the last save in case of a save button, or the presence of added files in a list of files in our.
I just can't see why we should make an exception from a perfectly good GUI defacto standard here, without getting a single benefit from doing so!


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-05-28 08:20:45 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.