[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suggestion for "select all" functionality in Commit dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 26 May 2009 19:24:07 +0200

On Tue, May 26, 2009 at 19:15, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> void pointer wrote:
>> On Tue, May 26, 2009 at 10:14 AM, Robert Dailey <rcdailey_at_gmail.com
>> <mailto:rcdailey_at_gmail.com>> wrote:
>>
>>     On Tue, May 26, 2009 at 1:24 AM, Hans-Emil Skogh
>>     <Hans-Emil.Skogh_at_tritech.se <mailto:Hans-Emil.Skogh_at_tritech.se>> wrote:
>>
>>         I see that Stefan has implemented the selection feature in the
>>         latest nightly.
>>
>>         Everything is much clearer now, and its a nice feature!
>>
>>         However, I do get slightly confused that all choices are
>>         clickable all the time. For exemple: I have deselcted "Show
>>         unversioned files". Then I click on "Check: Unversioned". This
>>         leads to all visible files being unchecked, but leaves me with
>>         an uncertain feeling: What did just happen? Are the unversioned
>>         files selected, but not shown? (No, they are not selected, as
>>         far as I can see. But it's still not clear.)
>>
>>         I would suggest to gray out the links that does would have the
>>         same effected as clicking "Check: None". That is, in my example
>>         above, "Check: Unversioned" would be grayed out, since there are
>>         no unversioned files shown.
>>
>>
>>     So if there are no Modified files shown, does that mean the
>>     "Modified" selection pattern should be grayed out? The same applies
>>     to "Added" or "Deleted" (If those exist).
>>
>>     The point is, this feature is not designed to be dynamic, at least
>>     as far as GMail is concerned. In GMail, the option to select all
>>     Unread items is still there even if there are no unread items in
>>     your view. The option does exactly what it says it does... it will
>>     select all Unversioned files, and "none" is considered "all" if
>>     there are no unversioned files shown.
>>
>>     I think the feature is perfect as-is and graying the options out
>>     would only confuse the feature (and the user) and make it less
>>     intuitive.
>>
>>
>> I just tried out this feature and I absolutely LOVE it. I have one small
>> suggestion for improvement, however. If you could make the links blue
>> instead of black, this would make them stand out a little better. Black,
>> to me, means static text and at first they did not appear clickable.
>>
>> This isn't a big deal but if you're open to the suggestion I'd like to
>> see the color changed :)
>
> One problem with blue: There is no pre-defined color for links in
> Windows. And that means we would have to make this configurable, which
> means again adding another color option in the settings dialog.

Or maybe not: COLOR_HOTLIGHT seems to be what we need.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2353974
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-05-26 19:24:46 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.